fix(runtime): propagate share scopes to nested remotes - #4913
Open
dmchoi77 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 20dfdaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagate the complete host share scope map when initializing a remote container.
Previously, only the share scope selected for the current remote was added to the remote container's runtime state. When that remote loaded another nested remote using a different share scope, the nested remote could not access shared dependencies from the upstream host. This could cause singleton dependencies such as React to be loaded more than once.
This change:
Host A → Remote B → Remote Cinitialization path with separate React 18 and React 19 share scopes.@module-federation/runtime-core.Validation
pnpm --filter @module-federation/runtime-core test -- instance.spec.tspnpm --filter @module-federation/runtime-core lintpnpm --filter @module-federation/runtime-core buildpnpm exec prettier --check packages/runtime-core/__tests__/instance.spec.ts packages/runtime-core/src/shared/index.ts .changeset/fix-nested-remote-share-scopes.mdRelated Issue
Fixes #4723
Types of changes
Checklist